Fix DST boundary issue occurring on Cloudflare env (fixes #108) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 72.89% 72.90%
=======================================
Files 32 32
Lines 2225 2233 +8
Branches 219 222 +3
=======================================
+ Hits 1622 1628 +6
- Misses 595 597 +2
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daylight savings hack. Cloudflare Workers uses a different Date implementation than Node 20.x, which doesn't seem to respect DST boundaries the same way (see: #108).
To work around this, instead of adding 1 day, we add 25 hours every increment (intentionally overshooting), then grab the start of the day from that time, and repeat. This works in both Node 20.x and the production Cloudflare Workers environment.
NOTE: There's already a DST boundary test, but it was always passing since it was running in a Node environment.